feat: PatchMeasure member expression #9218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
patch-measure-member-expression
branch
2 times, most recently
from
011a583 to
8792910
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9218 +/- ##
===========================================
+ Coverage 47.86% 76.56% +28.69%
===========================================
Files 171 400 +229
Lines 21312 105029 +83717
Branches 3687 3704 +17
===========================================
+ Hits 10201 80414 +70213
- Misses 10676 24179 +13503
- Partials 435 436 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcheshkov
force-pushed
the
patch-measure-member-expression
branch
from
214a45a to
6275676
Compare
waralexrom
approved these changes
Feb 13, 2025
| if (s.path()) { | ||
| return [s.cube().name].concat(this.evaluateSymbolSql(s.path()[0], s.path()[1], s.definition())); | ||
| } else if (s.patchedMeasure?.patchedFrom) { | ||
| return [s.patchedMeasure.patchedFrom[0]].concat(this.evaluateSymbolSql(s.patchedMeasure.patchedFrom[0], s.patchedMeasure.patchedFrom[1], s.definition())); |
Member
There was a problem hiding this comment.
Let's at least add the word Path to the name of the patchedFrom field (ideally, of course, make it a structure with cubeName and Name). Otherwise, every time we come across such a code fragment, we will have to go to the patchedMeasure definition to understand what patchedFrom and its 0th and 1st elements represent
MazterQyou
approved these changes
Feb 17, 2025
mcheshkov
force-pushed
the
patch-measure-member-expression
branch
from
6275676 to
88c5012
Compare
mcheshkov
force-pushed
the
patch-measure-member-expression
branch
from
88c5012 to
85910bb
Compare
mcheshkov
force-pushed
the
patch-measure-member-expression
branch
2 times, most recently
from
94afdf6 to
553c15f
Compare
waralexrom
approved these changes
Apr 8, 2025
…de::generate_sql_for_expr
…de::generate_column_expr
mcheshkov
force-pushed
the
patch-measure-member-expression
branch
from
553c15f to
d522158
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
Add new member expression: `PatchMeasure`. It allows to change aggregation type and add measure filters for existing measure. This is to allow queries like `MIN(avgMeasure)` and `SUM(CASE dim = 'foo' WHEN TRUE THEN sumMeasure ELSE NULL END)` in SQL API. Under the hood * SQL API now allows mismatched aggregation functions and aggregation on top of `CASE` in SQL pushdown rules, and rewrites that to special expression `__patch_measure(measure_column, 'new_agg_type', boolean_expression)` * This expression is syntactic-only, it should never execute, instead it would be handled by wrapper SQL generation * Generated member expression is passed to JS-side * `api-gateway` evaluates it from JSON from JS functions * `BaseQuery` and `BaseMeasure` now can handle new form: generate patched measure definition and use original measure during traversing and collecting Supporting changes * Changed rewrites for usual measures in SQL pushdown from just `measure_column` to `MEASURE(measure_column)`, to make rewrites uniform * Turn member expressions to tagged union in JSON representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Add new member expression:
PatchMeasure.It allows to change aggregation type and add measure filters for existing measure. This is to allow queries like
MIN(avgMeasure)andSUM(CASE dim = 'foo' WHEN TRUE THEN sumMeasure ELSE NULL END)in SQL API.Under the hood
CASEin SQL pushdown rules, and rewrites that to special expression__patch_measure(measure_column, 'new_agg_type', boolean_expression)api-gatewayevaluates it from JSON from JS functionsBaseQueryandBaseMeasurenow can handle new form: generate patched measure definition and use original measure during traversing and collectingSupporting changes
measure_columntoMEASURE(measure_column), to make rewrites uniform